Messages in this thread | | | Date | Wed, 21 Dec 2011 11:16:24 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2 v3] cgroup: Drop task_lock(parent) on cgroup_fork() |
| |
On Wed, Dec 21, 2011 at 08:03:19PM +0100, Frederic Weisbecker wrote: > We don't need to hold the parent task_lock() on the > parent in cgroup_fork() because we are already synchronized > against the two places that may change the parent css_set > concurrently: > > - cgroup_exit(), but the parent obviously can't exit concurrently > - cgroup migration: we are synchronized against threadgroup_lock() > > So we can safely remove the task_lock() there. > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Tejun Heo <tj@kernel.org> > Cc: Li Zefan <lizf@cn.fujitsu.com> > Cc: Containers <containers@lists.linux-foundation.org> > Cc: Cgroups <cgroups@vger.kernel.org> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: Oleg Nesterov <oleg@redhat.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Paul Menage <paul@paulmenage.org> > Cc: Mandeep Singh Baines <msb@chromium.org>
Applied both patches to cgroup/for-3.3 and pushed out to linux-next.
Thank you.
-- tejun
| |