lkml.org 
[lkml]   [2011]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: fix blk_queue_end_tag()
On Tue, Dec 20, 2011 at 11:30:14PM -0800, Williams, Dan J wrote:
> @@ -284,16 +284,7 @@ void blk_queue_end_tag(struct request_queue *q,
> struct request *rq)
> struct blk_queue_tag *bqt = q->queue_tags;
> int tag = rq->tag;
>
> - BUG_ON(tag == -1);
> -
> - if (unlikely(tag >= bqt->max_depth)) {
> - /*
> - * This can happen after tag depth has been reduced.
> - * But tag shouldn't be larger than real_max_depth.
> - */
> - WARN_ON(tag >= bqt->real_max_depth);
> - return;
> - }
> + BUG_ON(tag == -1 || tag > bqt->real_max_depth);

or ...

- int tag = rq->tag;
+ unsigned tag = rq->tag;
+ BUG_ON(tag >= bqt->real_max_depth);

since tags in the range INT_MIN to -2 are also a bug, right?

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."


\
 
 \ /
  Last update: 2011-12-21 14:23    [W:0.113 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site