lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue
    Date
    Am Dienstag, 20. Dezember 2011, 11:12:37 schrieb Daniel Kurtz:
    > > > Could you please be more specific about what this patch breaks and
    > > > perhaps give some guidance on how to fix it?
    > >
    > > It breaks nothing. It just continues a bug and I assumed it was not present.
    > > Basically the work queue must do nothing after pre_reset() and post_reset()
    > > ought to rerun the work in case some request came down during that time.
    >
    > So, is this an Ack for this patchset?
    > Can we fix any existing races in later patches?

    Very well. You are fixing a bad bug and not making matters worse.

    Acked-by: Oliver Neukum <oneukum@suse.de>

    Regards
    Oliver
    --
    - - -
    SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
    Maxfeldstraße 5
    90409 Nürnberg
    Germany
    - - -
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-20 11:19    [W:0.022 / U:59.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site