lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [RFC PATCH v3 1/5] dt: add of_get_child_count helper function
    Date
    > -----Original Message-----
    > From: Stephen Warren [mailto:swarren@nvidia.com]
    > Sent: Wednesday, December 21, 2011 7:59 AM
    > To: Dong Aisheng-B29396; linux-kernel@vger.kernel.org
    > Cc: linus.walleij@stericsson.com; s.hauer@pengutronix.de;
    > rob.herring@calxeda.com; linux-arm-kernel@lists.infradead.org;
    > kernel@pengutronix.de; cjb@laptop.org; devicetree-discuss@lists.ozlabs.org
    > Subject: RE: [RFC PATCH v3 1/5] dt: add of_get_child_count helper function
    > Importance: High
    >
    > Dong Aisheng wrote at Tuesday, December 20, 2011 10:41 AM:
    > > From: Dong Aisheng <dong.aisheng@linaro.org>
    > >
    > > Currently most code to get child count in kernel are almost same, add
    > > a helper to implement this function for dt to use.
    >
    > > diff --git a/include/linux/of.h b/include/linux/of.h
    >
    > > +static inline int of_get_child_count(const struct device_node *np) {
    > > + return -ENOSYS;
    > > +}
    >
    > Wouldn't it be better to return 0 here? -ENOSYS would be fine if the function
    > returned an error code, but it's really returning a count, and other "dummy"
    > functions that return data return 0/NULL already. This would also allow you to
    > just use the value directly in all cases rather than having to check for a < 0
    > error case.
    >
    Good point.
    Will update it next.

    Regards
    Dong Aisheng




    \
     
     \ /
      Last update: 2011-12-21 04:21    [W:0.025 / U:0.400 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site