lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5 V3] cgroup: remove redundate get/put of old css_set from migrate
Tejun Heo (tj@kernel.org) wrote:
> Hello,
>
> s/redundate/redundant/ in $SUBJ, right?
>
> On Tue, Dec 20, 2011 at 03:14:29PM -0800, Mandeep Singh Baines wrote:
> > Changes in V3:
> > * Fixed to put error in retval (thanks Frederic Weisbecker)
> > * https://lkml.org/lkml/2011/12/20/255
> > Changes in V2:
> > * Updated commit message as per Tejun's feedback:
> > * https://lkml.org/lkml/2011/12/19/289
> >
> > -- >8 -- (snip)
>
> Either put this as part of patch description or if you don't want it
> to be part of commit message, put it between --- and diffstat.
> Unfortunately, no tool understands "-- >8 --".
>

git-am should. From "man git-am":

-c, --scissors
Remove everything in body before a scissors line (see git-
mailinfo(1)).

From "man git-mailinfo":

--scissors
Remove everything in body before a scissors line. A line that
mainly consists of scissors (either ">8" or "8<") and perforation
(dash "-") marks is called a scissors line, and is used to request
the reader to cut the message at that line. If such a line appears
in the body of the message before the patch, everything before it
(including the scissors line itself) is ignored when this option is
used.

This is useful if you want to begin your message in a discussion
thread with comments and suggestions on the message you are
responding to, and to conclude it with a patch submission,
separating the discussion and the beginning of the proposed commit
log message with a scissors line.

This can enabled by default with the configuration option
mailinfo.scissors.

But I can stop using scissors if that is what you prefer.

> > We can now assume that the css_set reference held by the task
> > will not go away for an exiting task. PF_EXITING state can be
> > trusted throughout migration by checking it after locking
> > threadgroup.
> >
> > While at it, renamed css_set_check_fetched to css_set_fetched.
> > !css_set_fetched() seems to read better than
> > !css_set_check_fetched().
>
> I don't feel too hot about the renaming. Can you please drop it for
> now?
>

Sure. No problem.

> > Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Li Zefan <lizf@cn.fujitsu.com>
> > Cc: containers@lists.linux-foundation.org
> > Cc: cgroups@vger.kernel.org
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Paul Menage <paul@paulmenage.org>
>
> Other than that, looks good to me. I'll commit this once Li acks it.
>
> Thanks.
>
> --
> tejun


\
 
 \ /
  Last update: 2011-12-21 00:43    [from the cache]
©2003-2011 Jasper Spaans