lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] usb: musb: fix pm_runtime mismatches
From
On Tue, Dec 20, 2011 at 1:19 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Mon, Dec 19, 2011 at 10:20:09PM +0200, Felipe Contreras wrote:
>> On Mon, Dec 19, 2011 at 10:11 AM, Felipe Balbi <balbi@ti.com> wrote:
>> > On Fri, Dec 16, 2011 at 01:05:08AM +0200, Felipe Contreras wrote:
>> >> Properly call pm_runtime_put() afer pm_runttime_get() on errors.
>> >>
>> >> Untested.
>> >
>> > sorry, but I'm not applying untested patches. I need someone to give a
>> > Tested-by.
>>
>> I'm pretty sure most people don't test the exit paths, but fine, don't
>> apply them. Who needs power management anyway.
>
> if it wasn't tested you can't claim $SUBJECT makes PM magically work.

It's clear from the code, no need to test to see that pm_runtime_get()
is called but not pm_runtime_put(), thus the device remains active,
thus PM would not work after that.

--
Felipe Contreras


\
 
 \ /
  Last update: 2011-12-20 20:47    [from the cache]
©2003-2011 Jasper Spaans