lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] leds-tca6507: allow driver to compile when GPIOLIB is not available.
On 12/20/2011 12:16 PM, Randy Dunlap wrote:
> On 12/19/2011 09:44 PM, NeilBrown wrote:
>> This driver can configure the outputs as GPIO line instead of LEDs. But
>> that only works if GPIOLIB is available. So make that code conditional
>> on the library's availability.
>>
>> Also remove the 'teardown' callback as it is never called and should
>> never be needed.
>>
>> Signed-off-by: NeilBrown <neilb@suse.de>
>
> Thanks. This builds.
>
> Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Neil,
You might want to check this also:

drivers/leds/leds-tca6507.c:358:17: warning: array subscript is above array bounds
drivers/leds/leds-tca6507.c:357:17: warning: array subscript is above array bounds


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-12-20 20:29    [W:0.054 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site