lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] tracing, sched: Add a new tracepoint for sleeptime
From
Date
On Tue, 2011-12-20 at 10:22 -0800, Arun Sharma wrote:
> On 12/20/11 10:16 AM, Steven Rostedt wrote:
>
> >> +#ifdef CREATE_TRACE_POINTS
> >
> > Why the #ifdef? a static inline is fine to keep in the open. If nothing
> > uses it, then it just wont be used or defined.
> >
>
> Without the ifdef I get:
>
> In file included from include/trace/define_trace.h:80,
> from include/trace/events/sched.h:445,
> from kernel/sched/core.c:86:
> include/trace/events/sched.h:366: error: redefinition of
> ‘trace_get_sleeptime’
> include/trace/events/sched.h:366: note: previous definition of
> ‘trace_get_sleeptime’ was here
>
> So I shamelessly copied what the other static inline function in the
> file does.

Ah, OK, it's because of the duplicate includes. Still ugly though. But
we can clean that up later.


>
> I also noticed that sched_stat_sleeptime() is very similar to
> sched_stat_sleep(). The latter covers sleeps but not iowait and doesn't
> include the scheduler latency. Let me know if you think this is a show
> stopper that needs a rename.

what about sched_stat_iowait() too. As for latency, I don't know. That's
more Peter's decision.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-12-20 20:23    [W:0.043 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site