lkml.org 
[lkml]   [2011]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/7] Add assertion checking macros
Date
Andi Kleen <andi@firstfloor.org> wrote:

> David Howells <dhowells@redhat.com> writes:
> >
> > There is no need to display val here in the case the expression fails
> > since it can only be 0. If this fails, it produces an error like the
> > following:
> >
> > ------------[ cut here ]------------
> > kernel BUG at fs/fscache/main.c:109!
> > ASSERTION FAILED
>
> It would be nice to display the expression here like an user space
> assert. While it can be looked up in the source it would
> make quick eyeballing easier.
>
> Probably wouldn't cost too much additional text size?

It can easily be made selectable. I don't think text size should be much of
an issue - but it will also add a bunch of strings (preprocessed expressions)
to the rodata, and I'm not sure how big those can get - particularly if
they've got nested macros within (test_bit() for example).

David


\
 
 \ /
  Last update: 2011-12-20 16:41    [W:0.057 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site