Messages in this thread | | | Date | Mon, 19 Dec 2011 14:29:16 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 1/3] perf: __perf_evlist__mmap: Fix errno value on failed map. |
| |
Em Tue, Dec 20, 2011 at 12:33:30AM +0900, Namhyung Kim escreveu: > Nelson Elhage <nelhage@nelhage.com> writes: > > On failure, perf_evlist__mmap_per_{cpu,thread} will try to munmap() > > every map that doesn't have a NULL base. This will fail with EINVAL if > > one of them has base == MAP_FAILED, clobbering errno, so that > > perf_evlist__map will return EINVAL on any failure regardless of the > > root cause. > > > > Fix this by resetting failed maps to a NULL base. > > > > Signed-off-by: Nelson Elhage <nelhage@nelhage.com>
> Thanks for fixing this. I posted a basically same patch for this [1] > last week, but it seems my patch doesn't get included yet (right?), > and your patch looks bit simpler. So Arnaldo, I'm totally fine if you > decide to take this instead of mine.
Ok, and thank you both for the fixes, I was out on a business trip so a bit backlogged right now, will get to your patches as soon as possible,
Thanks!
- Arnaldo
> Thanks. > Namhyung Kim > > > [1] https://lkml.org/lkml/2011/12/12/275
| |