Messages in this thread | | | Date | Mon, 19 Dec 2011 17:05:12 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 9/9] usb: gadget: goku: use generic map/unmap routines |
| |
Hello.
On 19-12-2011 17:02, Sergei Shtylyov wrote:
>> those routines have everything we need to map/unmap >> USB requests and it's better to use them.
>> Signed-off-by: Felipe Balbi<balbi@ti.com> >> --- >> drivers/usb/gadget/goku_udc.c | 17 +++++++---------- >> 1 files changed, 7 insertions(+), 10 deletions(-)
>> diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c >> index 5af70fcc..bc47735 100644 >> --- a/drivers/usb/gadget/goku_udc.c >> +++ b/drivers/usb/gadget/goku_udc.c > [...] >> @@ -736,10 +732,11 @@ goku_queue(struct usb_ep *_ep, struct usb_request >> *_req, gfp_t gfp_flags) >> return -EBUSY;
>> /* set up dma mapping in case the caller didn't */ >> - if (ep->dma&& _req->dma == DMA_ADDR_INVALID) { >> - _req->dma = pci_map_single(dev->pdev, _req->buf, _req->length, >> - ep->is_in ? PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE); >> - req->mapped = 1; >> + if (ep->dma) { >> + status = usb_gadget_map_request(&dev->gadget, &req->req,
> Not '&_req->req'?
Or just '_req'?
WBR, Sergei
| |