Messages in this thread Patch in this message | | | Subject | [PATCH RESEND 3/3] mfd: tps6586x: Ensure setting bits if new value is different from the old value | From | Axel Lin <> | Date | Mon, 19 Dec 2011 19:59:31 +0800 |
| |
It does not make sense to write new value only when all the bit_mask bits are zero. We need to write new value if the bit mask fields of new value is not equal to old value.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/mfd/tps6586x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c index bba26d9..a5ddf31 100644 --- a/drivers/mfd/tps6586x.c +++ b/drivers/mfd/tps6586x.c @@ -197,7 +197,7 @@ int tps6586x_set_bits(struct device *dev, int reg, uint8_t bit_mask) if (ret) goto out; - if ((reg_val & bit_mask) == 0) { + if ((reg_val & bit_mask) != bit_mask) { reg_val |= bit_mask; ret = __tps6586x_write(to_i2c_client(dev), reg, reg_val); } -- 1.7.5.4
| |