lkml.org 
[lkml]   [2011]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/8] KVM: MMU: combine unsync and unsync_children
    About naming issues in the kvm mmu code.

    Not restricted to your patch series, so please take as a suggestion
    for the future.

    (2011/12/16 19:13), Xiao Guangrong wrote:
    > +static bool sp_is_unsync(struct kvm_mmu_page *sp)
    > +{
    > + return sp->role.level == PT_PAGE_TABLE_LEVEL&& sp->unsync;
    > +}

    is_unsync_sp() is more consistent with others?
    e.g. is_large_pte(), is_writable_pte(), is_last_spte()


    Takuya

    > +
    > +static unsigned int sp_unsync_children_num(struct kvm_mmu_page *sp)
    > +{
    > + unsigned int num = 0;
    > +
    > + if (sp->role.level != PT_PAGE_TABLE_LEVEL)
    > + num = sp->unsync_children;
    > +
    > + return num;
    > +}
    > +


    \
     
     \ /
      Last update: 2011-12-19 03:27    [W:3.241 / U:0.112 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site