lkml.org 
[lkml]   [2011]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] loop: fput() called in loop_clr_fd() may cause bd_mutex recursive locking
    On (12/17/11 22:58), Al Viro wrote:
    > On Sun, Dec 18, 2011 at 01:37:45AM +0300, Sergey Senozhatsky wrote:
    > > > Think of it for a minute - if we could run into the
    > > > same bdev in that recursion, what would have happened on read() from
    > > > that sucker? So yes, it is a false positive.
    > >
    > > I've tried read()/write() some time ago and it worked. Perhaps, I just
    > > wasn't "lucky" enough to hit any problems.
    >
    > Sure - exactly because of that loop prevention logics. *If* we really
    > had been able to set a loop0 -> loop1 -> loop2 -> loop0 or something of
    > that sort, this warning wouldn't be a false positive. But on any
    > such setup, where would IO attempts end up doing?

    Thanks for your explanations.

    > IOW, we have to prevent such setups anyway and not just because of
    > problems on close() - they would be deadly on read() and write()...
    >

    Preventing recursion in the first place? For example, in lo_open()?


    Sergey


    \
     
     \ /
      Last update: 2011-12-18 00:27    [W:0.022 / U:95.664 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site