lkml.org 
[lkml]   [2011]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: Fix cross compilation broken by failing size command
On Fri, Dec 16, 2011 at 11:42:26AM +0100, Janusz Krzysztofik wrote:
> Unfortunately, I've already pushed that old version to the patch system
> at http://www.arm.linux.org.uk/developer/patches/, which I know is not
> a review system. Apparently, I was not patient enough, not waiting more
> than a week with that regression fix for a single reply to my initial

I'll disagree with you there: this is not a regression fix. A regression
fix implies that it was something that worked before, a change happened
to the kernel, and now it's broken.

That is not the case: a change happened to binutils which meant 'size'
no longer parses foreign ELF formats. This is not a change to the
kernel, and therefore it is not a kernel regression.

Therefore, I consider it lower priority than true kernel regression
fixes, and also lower priority than normal bug fixes to the kernel:
it's actually a feature change - changing the kernel to work with a
new toolchain.

Since the original proposed change causes _me_ problems (I'm missing
an arm-linux-size for some unknown reason - which I've yet to resolve
one way or other) I've not yet considered the change any further than
noting that fact.

If it turns out that older versions of binutils do not supply a 'size'
command, then we need something like your v2 patch. If it's the case
that for some reason it never got transferred when I changed machines,
then your v1 patch is appropriate and I need to fix that. But that
requires investigation on my side, and I've not been able to do that
yet.


\
 
 \ /
  Last update: 2011-12-17 12:01    [W:0.052 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site