lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Use -m-omit-leaf-frame-pointer to shrink text size

* Ingo Molnar <mingo@elte.hu> wrote:

> [...]
>
> The call-chains are still intact for quality backtraces and
> for call-chain profiling (perf record -g), as the backtrace
> walker can deduct the full backtrace from the RIP of a leaf
> function and the parent chain.

Hm, noticed one complication while looking at annotated assembly
code in perf top. Code doing function calls from within asm() is
incorrectly marked 'leaf' by GCC:

ffffffff812b82d8 <arch_local_save_flags>:
ffffffff812b82d8: ff 14 25 00 d9 c1 81 callq *0xffffffff81c1d900
ffffffff812b82df: c3 retq

So all the paravirt details will have to be fixed, so that GCC
is able to see that there's a real function call done inside.
Jeremy, Konrad?

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-12-16 09:57    [W:0.062 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site