lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: linux-next: build failure after merge of the regmap tree
    On Fri, Dec 16, 2011 at 1:15 AM, Ashish Jangam
    <Ashish.Jangam@kpitcummins.com> wrote:
    > -----Original Message-----
    > From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely
    > Sent: Friday, December 16, 2011 1:41 PM
    > To: Ashish Jangam
    > Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Mark Brown; Dajun
    > Subject: Re: linux-next: build failure after merge of the regmap tree
    >
    > On Fri, Dec 16, 2011 at 12:19 AM, Ashish Jangam
    > <Ashish.Jangam@kpitcummins.com> wrote:
    >>
    >>
    >> -----Original Message-----
    >> From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of Grant Likely
    >> Sent: Thursday, December 15, 2011 11:55 PM
    >> To: Ashish Jangam
    >> Cc: Stephen Rothwell; linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Mark Brown; Dajun
    >> Subject: Re: linux-next: build failure after merge of the regmap tree
    >>
    >> On Thu, Dec 15, 2011 at 2:25 AM, Ashish Jangam
    >> <ashish.jangam@kpitcummins.com> wrote:
    >>> Fixes DA9052 GPIO errors.
    >>>
    >>> This patch is functionally tested on Samsung SMDKV6410.
    >>>
    >>> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
    >>> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
    >>> ---
    >>>  drivers/gpio/gpio-da9052.c      |   37 ++++--------------------------
    >>>  include/linux/mfd/da9052/gpio.h |   48 +++++++++++++++++++++++++++++++++++++++
    >>
    >> gpio-da9052.c is the only users of mfd/da9052/gpio.h.  Why is this
    >> include file needed?  The #defines can simply stay in the .c file.
    >> I've picked up the patch, but modified it to keep the header defines
    >> in the .c file.  If there is a reason this won't work, then please let
    >> me know.
    >>
    >> This header file is shared between GPIO and LED module. I have already
    >> posted this LED long back got ACK but did not got merged due to its
    >> dependency on MFD module.
    >
    > Are the LEDs attached to GPIOs?  If so, then is there a reason that
    > the leds-gpio driver can't be used?
    >
    > Oh yes we can use leds-gpio driver.

    Please do, and keep the gpio internal details in the .c file. Thanks,

    g.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-16 09:29    [W:0.025 / U:1.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site