lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[26/53] target/file: walk properly over sg list
    3.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

    commit 9649fa1b8764f64c8cc4293e197e14cd46fe7205 upstream.

    This patch changes fileio to use for_each_sg() when walking se_task->task_sg
    memory passed into from loopback LLD struct scsi_cmnd scatterlist memory.

    This addresses an issue where FILEIO backends with loopback where hitting the
    following OOPs with mkfs.ext2:

    |kernel BUG at include/linux/scatterlist.h:97!
    |invalid opcode: 0000 [#1] PREEMPT SMP
    |Modules linked in: sd_mod tcm_loop target_core_stgt scsi_tgt target_core_pscsi target_core_file target_core_iblock target_core_mod configfs scsi_mod
    |
    |Pid: 671, comm: LIO_fileio Not tainted 3.1.0-rc10+ #139 Bochs Bochs
    |EIP: 0060:[<e0afd746>] EFLAGS: 00010202 CPU: 0
    |EIP is at fd_do_task+0x396/0x420 [target_core_file]
    | [<e0aa7884>] __transport_execute_tasks+0xd4/0x190 [target_core_mod]
    | [<e0aa797c>] transport_execute_tasks+0x3c/0xf0 [target_core_mod]
    |EIP: [<e0afd746>] fd_do_task+0x396/0x420 [target_core_file] SS:ESP 0068:dea47e90

    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Cc: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/target/target_core_file.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    --- a/drivers/target/target_core_file.c
    +++ b/drivers/target/target_core_file.c
    @@ -288,9 +288,9 @@ static int fd_do_readv(struct se_task *t
    return -ENOMEM;
    }

    - for (i = 0; i < task->task_sg_nents; i++) {
    - iov[i].iov_len = sg[i].length;
    - iov[i].iov_base = sg_virt(&sg[i]);
    + for_each_sg(task->task_sg, sg, task->task_sg_nents, i) {
    + iov[i].iov_len = sg->length;
    + iov[i].iov_base = sg_virt(sg);
    }

    old_fs = get_fs();
    @@ -340,9 +340,9 @@ static int fd_do_writev(struct se_task *
    return -ENOMEM;
    }

    - for (i = 0; i < task->task_sg_nents; i++) {
    - iov[i].iov_len = sg[i].length;
    - iov[i].iov_base = sg_virt(&sg[i]);
    + for_each_sg(task->task_sg, sg, task->task_sg_nents, i) {
    + iov[i].iov_len = sg->length;
    + iov[i].iov_base = sg_virt(sg);
    }

    old_fs = get_fs();



    \
     
     \ /
      Last update: 2011-12-16 21:09    [W:0.031 / U:179.576 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site