lkml.org 
[lkml]   [2011]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
At Thu, 15 Dec 2011 18:24:54 +0100,
Joerg Roedel wrote:
>
> On Thu, Dec 15, 2011 at 11:16:52PM +0600, Rakib Mullick wrote:
> > On Thu, Dec 15, 2011 at 10:52 PM, Joerg Roedel <joerg.roedel@amd.com> wrote:
> > > (again with mailing lists on Cc, sorry)
> > >
> > > Hi,
> > >
> > > I tested current linux-next against my iommu-configs and found a compile
> > > error in sound/soc/mid-x86/sst_platform.c. The variable ret_val in the
> > > sst_platform_open() function is used but not declared. Attached patch
> > > fixes this.
> > >
> >
> > While fixing any kind of error/warning, it's nice to have
> > error/warning message in changelog.
>
> Okay, here it is:
>
> >From 9d0876632c4fc07254eafbe5018e68963bdcfe17 Mon Sep 17 00:00:00 2001
> From: Joerg Roedel <joerg.roedel@amd.com>
> Date: Thu, 15 Dec 2011 17:39:31 +0100
> Subject: [PATCH] Fix compile error in sound/soc/mid-x86/sst_platform.c
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> The variable ret_val is used but not declared. This causes
> the following compile error:
>
> sound/soc/mid-x86/sst_platform.c: In function ‘sst_platform_open’:
> sound/soc/mid-x86/sst_platform.c:274:2: error: ‘ret_val’ undeclared (first use in this function)
> sound/soc/mid-x86/sst_platform.c:274:2: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [sound/soc/mid-x86/sst_platform.o] Error 1
>
> Fix this.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Thanks, I applied the patch now to sound git tree.

Mark, could you merge back topic/asoc branch into your tree later?


Takashi



> ---
> sound/soc/mid-x86/sst_platform.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/mid-x86/sst_platform.c b/sound/soc/mid-x86/sst_platform.c
> index 24f9471..11c39c5 100644
> --- a/sound/soc/mid-x86/sst_platform.c
> +++ b/sound/soc/mid-x86/sst_platform.c
> @@ -267,6 +267,7 @@ static int sst_platform_open(struct snd_pcm_substream *substream)
> {
> struct snd_pcm_runtime *runtime = substream->runtime;
> struct sst_runtime_stream *stream;
> + int ret_val;
>
> pr_debug("sst_platform_open called\n");
>
> --
> 1.7.5.4
>
>
> --
> AMD Operating System Research Center
>
> Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
> General Managers: Alberto Bozzo, Andrew Bowd
> Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-12-16 07:55    [W:0.042 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site