lkml.org 
[lkml]   [2011]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/7] VFS: Rename and refactor writeback_inodes_sb_if_idle
Ping...

On tue, 13 Dec 2011 11:34:05 +0800, Miao Xie wrote:
> On thu, 8 Dec 2011 10:04:34 -0800, Kamal Mostafa wrote:
>> /**
>> - * writeback_inodes_sb_if_idle - start writeback if none underway
>> + * try_to_writeback_inodes_sb_nr - start writeback if none underway
>> * @sb: the superblock
>> * @nr: the number of pages to write
>> *
>> * Invoke writeback_inodes_sb if no writeback is currently underway.
>> * Returns 1 if writeback was started, 0 if not.
>> */
>> -int writeback_inodes_sb_nr_if_idle(struct super_block *sb,
>> +int try_to_writeback_inodes_sb_nr(struct super_block *sb,
>> unsigned long nr,
>> enum wb_reason reason)
>> {
>> if (!writeback_in_progress(sb->s_bdi)) {
>> down_read(&sb->s_umount);
>> - writeback_inodes_sb_nr(sb, nr, reason);
>> + if (nr == 0)
>> + writeback_inodes_sb(sb, reason);
>> + else
>> + writeback_inodes_sb_nr(sb, nr, reason);
>> up_read(&sb->s_umount);
>> return 1;
>> } else
>> return 0;
>
> The comment said "Returns 1 if writeback was started", so if writeback_in_progress()
> return true, I think this function also should return 1.
>
> BTW: Does anyone know when this patchset will be merged into the main tree?
>
> Thanks
> Miao
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>



\
 
 \ /
  Last update: 2011-12-15 08:13    [from the cache]
©2003-2011 Jasper Spaans