Messages in this thread | | | Date | Wed, 14 Dec 2011 23:06:56 -0800 | Subject | Re: [PATCH v2011.2] fs: symlink restrictions on sticky directories | From | Kees Cook <> |
| |
On Wed, Dec 14, 2011 at 10:48 PM, Ingo Molnar <mingo@elte.hu> wrote:
> * Kees Cook <keescook@chromium.org> wrote: > >> + ab = audit_log_start(current->audit_context, >> + GFP_ATOMIC, AUDIT_AVC); > > Hm, is GFP_ATOMIC really necessary here? Why not GFP_KERNEL? > This is in VFS process context, not in some atomic context that > has to be careful about allocations, right?
Hm, that's true. I had started from the lsm_audit interface, but had to expand it, and in the process copied its use of audit_log_start(). But yeah, I don't see a reason it can't be GFP_KERNEL. I'll adjust it.
Thanks!
-Kees
-- Kees Cook ChromeOS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |