lkml.org 
[lkml]   [2011]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] x86, mce: create helper function to save addr/misc when needed
(2011/12/14 2:48), Tony Luck wrote:
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> index 265139d..43f22c8 100644
> --- a/arch/x86/kernel/cpu/mcheck/mce.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> @@ -492,6 +492,27 @@ static void mce_report_event(struct pt_regs *regs)
> irq_work_queue(&__get_cpu_var(mce_irq_work));
> }
>
> +/*
> + * Read ADDR and MISC registers.
> + */
> +static void mce_read_aux(struct mce *m, int i)
> +{
> + if (m->status & MCI_STATUS_MISCV)
> + m->misc = mce_rdmsrl(MSR_IA32_MCx_MISC(i));
> + if (m->status & MCI_STATUS_ADDRV) {
> + m->addr = mce_rdmsrl(MSR_IA32_MCx_ADDR(i));
> +
> + /*
> + * Mask the reported address by the reported granularity.
> + */
> + if (mce_ser && (m->status & MCI_STATUS_MISCV)) {
> + u8 shift = m->misc & 0x3f;

(nitpick) You can use:

#define MCI_MISC_ADDR_LSB(m) ((m) & 0x3f)

> + m->addr >>= shift;
> + m->addr <<= shift;
> + }
> + }
> +}
> +
> DEFINE_PER_CPU(unsigned, mce_poll_count);
>
> /*

Thanks,
H.Seto



\
 
 \ /
  Last update: 2011-12-16 01:17    [W:0.118 / U:2.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site