lkml.org 
[lkml]   [2011]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] trace: add ability to collect call chain of non-current task.


On 12/15/11 7:19 AM, Andrew Vagin wrote:

>>> * It doesn't distinguish blocking time and sleeping time.
>>
>> Can't we distinguish based on next->state?
> It will be "Running". We can distinguish based on block_start of
> sleep_start

Sounds good.

>>
>>> * This patch does a bit mess between subsystems...
>>
>> Which subsystems?
> sched_switch belongs to scheduler.
> sched_stat belongs to sched_fair.
>

My reading of the code is that 'struct sched_statistics' is independent
of the scheduling class. But only sched_fair.c is actually populating
the stats. Other classes could populate those fields if they choose to.

> It works for me. You can find output of commands bellow.
>
> # ./perf record -e sched:sched_switch -agP

Thanks. I forgot to use the -P option you added on my cmdline.

I still need to investigate why per-process mode (command line without
-a) doesn't work. Will send an updated patch once that's fixed.

-Arun



\
 
 \ /
  Last update: 2011-12-15 20:11    [from the cache]
©2003-2011 Jasper Spaans