Messages in this thread | | | Date | Thu, 15 Dec 2011 18:25:45 +0100 | From | Samuel Ortiz <> | Subject | Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC |
| |
Hi Arnd,
On Thu, Dec 15, 2011 at 03:34:01PM +0000, Arnd Bergmann wrote: > On Thursday 15 December 2011, MyungJoo Ham wrote: > > Arnd Bergmann wrote: > > > On Monday 12 December 2011, Samuel Ortiz wrote: > > > The part that is not clear to me is how this new driver fits in > > > with the first fsa9480 driver and the currently discussed extcon > > > subsystem, apparently all written by the same team at Samsung. > > > Is this misc driver still useful when the extcon framework gets > > > merged? > > > > When extcom gets merged, this driver should be updated. It looks like allowing > > the interrupt handler to update extcon state would be enough. Bascially, this > > is all this driver is required for extcon to work. (and the prvious author of > > extcon--"extended" switch class at that time--was the author of this patch.) > > > > Anyway, this patch has just told me that I'll need to add more sysfs entries > > for extcon to show the list of cable names and/or to show the status for each > > of them, soon or later. > > I think it would be better not to merge this driver until the user interface > in the extcon framework has been finalized. I don't mind the driver, but I > want to prevent user interfaces from appearing in the kernel that we > intend to change anyway. > > How about dropping the driver from the mfd tree, and adding it into the > extcon series for the next posting? Sounds good to me, I'll drop it.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |