Messages in this thread | | | Date | Thu, 15 Dec 2011 10:32:18 +0100 | From | Sascha Hauer <> | Subject | Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux subsystem |
| |
On Thu, Dec 15, 2011 at 07:23:42AM +0000, Dong Aisheng-B29396 wrote: > > -----Original Message----- > > From: Linus Walleij [mailto:linus.walleij@linaro.org] > > Sent: Thursday, December 15, 2011 6:16 AM > > To: Sascha Hauer > > Cc: Dong Aisheng-B29396; linus.walleij@stericsson.com; linux- > > kernel@vger.kernel.org; rob.herring@calxeda.com; > > grant.likely@secretlab.ca; linux-arm-kernel@lists.infradead.org; > > kernel@pengutronix.de; Guo Shawn-R65073 > > Subject: Re: [RFC PATCH v2 4/4] mmc: sdhci-esdhc-imx: using pinmux > > subsystem > > Importance: High > > > > On Wed, Dec 14, 2011 at 10:11 PM, Sascha Hauer <s.hauer@pengutronix.de> > > wrote: > > > On Thu, Dec 15, 2011 at 12:03:42AM +0800, Dong Aisheng wrote: > > > > >> + pmx = pinmux_get(&pdev->dev, NULL); > > >> + if (IS_ERR(pmx)) { > > >> + err = PTR_ERR(pmx); > > >> + goto err_pmx_get; > > >> + } > > >> + err = pinmux_enable(pmx); > > >> + if (err) > > >> + goto err_pmx_enable; > > >> + imx_data->pmx = pmx; > > >> + > > > > > > Won't this break every i.MX except i.MX6? > > > > If not select PINCTRL, pinmux_enable returns ok by default and pinmux_get > Returns NULL which also does not block. > So it will not break other i.MX currently since only mx6q are using PINCTRL. > > > Not this patch on its own, first the machines have to select PINCTRL > > select PINMUX_FOO > > > > *Then* it will break :-D > > > > After we move to one single image for mx5 and mx6, it could be an issue > Since PINCTRL may be selected by default. > So mx5 pinmux driver is in my TODO list.
Add i.MX3 which is compiled together with i.MX6 :)
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |