lkml.org 
[lkml]   [2011]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend] audit: fix mark refcounting
On Thu, Dec 15, 2011 at 09:56:26AM +0100, Miklos Szeredi wrote:

> > Guys, does anybody have a real demonstration of the breakage cured by
> > pinning the mark down in audit_watch.c ->handle_event()? Or is that
> > a pure theory?
>
> Yes it does fix the BUG. Test case in patch.
>
> > Is ->handle_event() argument held by caller?
>
> Well, obviously not, otherwise we wouldn't hit the bug.
>
> > Eric? If that's the case,
> > we don't need to do anything with audit_watch.c instance; otherwise,
> > both that one and inotify_handle_event() are in trouble...
>
> Yep.

I wonder if the right fix is to do it here and not in caller, though...
OTOH, usually we don't hit destroy at all, so it's probably better to
handle it in the individual instances...

OK, consider the audit_watch.c part ACKed; inotify counterpart needs a similar
patch, AFAICS.


\
 
 \ /
  Last update: 2011-12-15 10:05    [from the cache]
©2003-2011 Jasper Spaans