Messages in this thread | | | From | Miklos Szeredi <> | Subject | Re: [PATCH resend] audit: fix mark refcounting | Date | Thu, 15 Dec 2011 09:49:39 +0100 |
| |
Linus Torvalds <torvalds@linux-foundation.org> writes:
> Looks reasonable, but why doesn't all callers have that "put_mark()" thing? > > And if/when all callers *do* have that put_mark() thing, maybe we > should make destroy_mark() just do it? > > In particular, a quick grep shows that there are destroy_mark users still in: > > - fs/notify/fanotify/fanotify_user.c > > - fs/notify/dnotify/dnotify.c (2 of them)
These do in fact do "put_mark()" after the "destroy_mark()".
> > - fs/notify/inotify/inotify_fsnotify.c
This one, I think, is broken.
Thanks, Miklos
| |