lkml.org 
[lkml]   [2011]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH resend] audit: fix mark refcounting
Date
Linus Torvalds <torvalds@linux-foundation.org> writes:

> Looks reasonable, but why doesn't all callers have that "put_mark()" thing?
>
> And if/when all callers *do* have that put_mark() thing, maybe we
> should make destroy_mark() just do it?
>
> In particular, a quick grep shows that there are destroy_mark users still in:
>
> - fs/notify/fanotify/fanotify_user.c
>
> - fs/notify/dnotify/dnotify.c (2 of them)

These do in fact do "put_mark()" after the "destroy_mark()".

>
> - fs/notify/inotify/inotify_fsnotify.c

This one, I think, is broken.

Thanks,
Miklos


\
 
 \ /
  Last update: 2011-12-15 09:53    [W:0.151 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site