lkml.org 
[lkml]   [2011]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Fix for binary_sysctl() memory leak
    Date
    binary_sysctl() calls sysctl_getname() which allocates from
    names_cache slab usin __getname()

    The matching function to free the name is __putname(), and not
    putname() which should be used only to match getname() allocations.

    Signed-off-by: Michel Lespinasse <walken@google.com>
    ---
    kernel/sysctl_binary.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
    index e8bffbe..2ce1b30 100644
    --- a/kernel/sysctl_binary.c
    +++ b/kernel/sysctl_binary.c
    @@ -1354,7 +1354,7 @@ static ssize_t binary_sysctl(const int *name, int nlen,

    fput(file);
    out_putname:
    - putname(pathname);
    + __putname(pathname);
    out:
    return result;
    }
    --
    1.7.3.1


    \
     
     \ /
      Last update: 2011-12-15 03:47    [W:0.022 / U:29.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site