lkml.org 
[lkml]   [2011]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] input: signedness bug in cma3000_thread_irq()
From
Date
On Mon, 12 Dec 2011 01:49:26 EST, Xi Wang said:
> The error check (intr_status < 0) didn't work because intr_status is
> a u8. Change its type to signed int.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
> ---
> drivers/input/misc/cma3000_d0x.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c

That will fix the signed/unsigned issue. However, was there a reason
the field was an 8-bit-wide to begin with?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-12-15 03:29    [from the cache]
©2003-2011 Jasper Spaans