lkml.org 
[lkml]   [2011]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/4] efi: Only create sysfs entries while booting or running
    On Wed, Dec 14, 2011 at 1:06 PM, Matthew Garrett <mjg@redhat.com> wrote:
    > There's no point in creating sysfs entries while the machine's on its way
    > down. Skip it in that case in order to avoid complexity.
    >
    > Signed-off-by: Matthew Garrett <mjg@redhat.com>

    Acked-by: Mike Waychison <mikew@google.com>

    > ---
    >  drivers/firmware/efivars.c |   17 ++++++++++++-----
    >  1 files changed, 12 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
    > index b0a8117..eb07f13 100644
    > --- a/drivers/firmware/efivars.c
    > +++ b/drivers/firmware/efivars.c
    > @@ -552,11 +552,18 @@ static int efi_pstore_write(enum pstore_type_id type, u64 *id,
    >        if (found)
    >                efivar_unregister(found);
    >
    > -       if (size)
    > -               ret = efivar_create_sysfs_entry(efivars,
    > -                                         utf16_strsize(efi_name,
    > -                                                       DUMP_NAME_LEN * 2),
    > -                                         efi_name, &vendor);
    > +       if (size) {
    > +               switch (system_state) {
    > +               case SYSTEM_BOOTING:
    > +               case SYSTEM_RUNNING:
    > +                       ret = efivar_create_sysfs_entry(efivars,
    > +                                                       utf16_strsize(efi_name,
    > +                                                           DUMP_NAME_LEN * 2),
    > +                                                       efi_name, &vendor);
    > +               default:
    > +                       break;
    > +               }
    > +       }
    >
    >        *id = part;
    >        return ret;
    > --
    > 1.7.7.1
    >
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-12-14 22:41    [W:0.023 / U:64.428 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site