lkml.org 
[lkml]   [2011]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] jump-label: initialize jump-label subsystem somewhat later
On 12/14/2011 08:51 AM, Peter Zijlstra wrote:
> On Wed, 2011-12-14 at 08:48 -0800, David Daney wrote:
>> From: David Daney<david.daney@cavium.com>
>>
>> commit 97ce2c88f9ad42e3c60a9beb9fca87abf3639faa breaks MIPS.
>>
>> The jump-lable initialization does I-Cache flushing after modifying
>> code. On MIPS this is done by calling through the function pointer
>> flush_icache_range(). This function pointer is initialized mm_init().

Actually I misspoke, for MIPS we need jump_label_init() after
trap_init(), not mm_init().

>>
>> As things stand, we cannot be calling jump_label_init() until after
>> mm_init() completes, so we move the call down to satisfy this
>> constraint.
>
> I'm fine as long as it stays before sched_init(), which it does. Jeremy
> is this still early enough for you?
>

Just tested a revised patch that moves it to between trap_init() and
mm_init(), I propose that we do that instead.

New patch in a couple of minutes.

David Daney


\
 
 \ /
  Last update: 2011-12-14 18:19    [W:0.273 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site