Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC | Date | Wed, 14 Dec 2011 16:35:54 +0000 |
| |
On Monday 12 December 2011, Samuel Ortiz wrote: > On Thu, Nov 24, 2011 at 06:12:18PM +0900, Donggeun Kim wrote: > > The MUIC function in MAX8997 device can be used as > > a USB port detector and switch. > > This patch supports the MUIC feature of MAX8997. > > I'm queueing this one to my for-next branch as it depends on your previous MFD > patch. > I'm also cc'ing Arnd in case he has some objections.
Thanks for the notification!
First of all, every new user space interface including new sysfs files and uevent messages needs documentation in the Documentation/ABI directory.
The part that is not clear to me is how this new driver fits in with the first fsa9480 driver and the currently discussed extcon subsystem, apparently all written by the same team at Samsung. Is this misc driver still useful when the extcon framework gets merged?
I very much believe that we should avoid introducing user interfaces in a driver specific way when we have multiple pieces of hardware that try to do the same thing. The extcon subsystem seems to handle this correctly on the high-level (I have not done a detailed review yet but I trust that it will be ok), so I don't understand why we want another driver for the MAX8997 MUIC.
Arnd
| |