lkml.org 
[lkml]   [2011]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Is per_cpu_ptr_to_phys broken?
From
On Wed, Dec 14, 2011 at 7:33 AM, Petr Tesarik <ptesarik@suse.cz> wrote:
> Hi folks,
>
...
>
> Now, the per_cpu_ptr_to_phys() function aligns all vmalloc addresses to a page
> boundary. This was probably right when Vivek Goyal introduced that function
> (commit 3b034b0d084221596bf35c8d893e1d4d5477b9cc), because per-cpu addresses
> were only allocated by vmalloc if booted with percpu_alloc=page, but this is
> no longer the case, because per-cpu variables are now always allocated that
> way AFAICS.
>
> So, shouldn't we add the offset within the page inside per_cpu_ptr_to_phys?
>

Hi,

Tejun already fixed this, see:

commit a855b84c3d8c73220d4d3cd392a7bee7c83de70e
percpu: fix chunk range calculation
author Tejun Heo <tj@kernel.org>


\
 
 \ /
  Last update: 2011-12-14 17:19    [W:0.054 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site