[lkml]   [2011]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/3] make clone_children a flag
    Tejun Heo wrote:
    > On Sun, Dec 11, 2011 at 03:45:37PM +0100, Glauber Costa wrote:
    >> There is no reason to have a flags field, and then a separate
    >> bool field just to indicate if the clone_children flag is set.
    >> Make it a flag
    >> Signed-off-by: Glauber Costa <>
    > Doesn't this change how remount conditions are checked?

    Right. Currently we can do this:

    # mount -t cgroup xxx /mnt
    # mount -o remount,clone_children /mnt

    with this patch, the above remount will fail.

    But..the current bevaiour of remount is a bit confusing in that remount
    with/without "clone_children" has no effect on anything:

    # mount -t cgroup -o clone_children xxx /mnt
    # cat /mnt/cgroup.clone_children
    # mount -o remount xxx /mnt
    # mount | grep cgroup
    xxx on /mnt type cgroup (rw,clone_children)
    # cat /mnt/cgroup.clone_children

     \ /
      Last update: 2011-12-14 03:29    [W:0.019 / U:37.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site