lkml.org 
[lkml]   [2011]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 29/29] Staging: comedi: fix printk issue in contec_pci_dio.c
On Mon, Dec 12, 2011 at 10:49:41AM +0530, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the contec_pci_dio.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
>
> Converted printks to dev_<levels> and Removed unnecessary
> printk statements.

You forgot to add to the changelog entry this text:

Breaks the build.

which would have saved me a lot of time tracking down the patch in this
series that was causing problems.

{sigh}
Your next patch series better come with perfectly spelled changelog
entries that actually describe what the patches do, numbered properly
(none of this 30/30 crap after a 00/29 series), not break the build (is
that asking too much?) apply with no fuzz, and to help it all out, a
home made holiday bread of your choosing, as long as it's fresh, and
does not contain dried fruit bits (soaked in liquor can't hurt either.)

Otherwise I'm very tempted to just add you to my kill file, it would
save me lots of time and frustration, and likewise, I'm sure yours as
well.

Get baking,

greg k-h


\
 
 \ /
  Last update: 2011-12-14 01:53    [from the cache]
©2003-2011 Jasper Spaans