lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 06/25] dynamic_debug: replace strcpy with strlcpy, in ddebug_setup_query()
    Date
    From: Jim Cromie <jim.cromie@gmail.com>

    replace strcpy with strlcpy, and add define for the size constant.

    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    lib/dynamic_debug.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    index 8c88b89..101e2e5 100644
    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -525,14 +525,16 @@ EXPORT_SYMBOL(__dynamic_netdev_dbg);

    #endif

    -static __initdata char ddebug_setup_string[1024];
    +#define DDEBUG_STRING_SIZE 1024
    +static __initdata char ddebug_setup_string[DDEBUG_STRING_SIZE];
    +
    static __init int ddebug_setup_query(char *str)
    {
    if (strlen(str) >= 1024) {
    pr_warn("ddebug boot param string too large\n");
    return 0;
    }
    - strcpy(ddebug_setup_string, str);
    + strlcpy(ddebug_setup_string, str, DDEBUG_STRING_SIZE);
    return 1;
    }

    --
    1.7.7.3


    \
     
     \ /
      Last update: 2011-12-13 00:21    [W:9.405 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site