lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 29/29] Staging: comedi: fix printk issue in contec_pci_dio.c
Date
This is a patch to the contec_pci_dio.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels> and Removed unnecessary
printk statements.

Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/comedi/drivers/contec_pci_dio.c b/drivers/staging/comedi/drivers/contec_pci_dio.c
index e3659bd..a3231fe 100644
--- a/drivers/staging/comedi/drivers/contec_pci_dio.c
+++ b/drivers/staging/comedi/drivers/contec_pci_dio.c
@@ -105,8 +105,6 @@ static int contec_attach(struct comedi_device *dev, struct comedi_devconfig *it)
struct pci_dev *pcidev = NULL;
struct comedi_subdevice *s;

- printk("comedi%d: contec: ", dev->minor);
-
dev->board_name = thisboard->name;

if (alloc_private(dev, sizeof(struct contec_private)) < 0)
@@ -132,7 +130,7 @@ static int contec_attach(struct comedi_device *dev, struct comedi_devconfig *it)
return -EIO;
}
dev->iobase = pci_resource_start(pcidev, 0);
- printk(" base addr %lx ", dev->iobase);
+ dev_dbg("base addr %lx\n", dev->iobase);

dev->board_ptr = contec_boards + 0;

@@ -153,20 +151,18 @@ static int contec_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->range_table = &range_digital;
s->insn_bits = contec_do_insn_bits;

- printk("attached\n");

return 1;
}
}

- printk("card not present!\n");
+ dev_err(dev->hw_dev, "card not present!\n");

return -EIO;
}

static int contec_detach(struct comedi_device *dev)
{
- printk("comedi%d: contec: remove\n", dev->minor);

if (devpriv && devpriv->pci_dev) {
if (dev->iobase)
--
1.7.0.4


\
 
 \ /
  Last update: 2011-12-12 06:37    [W:0.336 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site