Messages in this thread | | | Date | Mon, 12 Dec 2011 07:24:41 -0800 | From | Greg KH <> | Subject | Re: [PATCH 3/3] kref: Remove the memory barriers |
| |
On Mon, Dec 12, 2011 at 09:55:57AM +0100, Peter Zijlstra wrote: > On Mon, 2011-12-12 at 11:48 +0800, Ming Lei wrote: > > We can't assume any lock about kref usage, because kref is often used > > in lockless scenario. > > Then you're doing it wrong, seriously. > > kref in lockless scenarios simply doesn't work, you need rcu (or another > means to stabilize storage) and atomic_inc_not_zero() as well as means > to validate your object after the lookup.
I agree, and I'll apply your patches later today, thanks for doing them.
greg k-h
| |