Messages in this thread Patch in this message | | | Date | Mon, 12 Dec 2011 21:49:18 +0800 | Subject | Re: [PATCH] mm: memcg: keep root group unchanged if fail to create new | From | Hillf Danton <> |
| |
On Mon, Dec 12, 2011 at 9:11 PM, Michal Hocko <mhocko@suse.cz> wrote: > > Hillf could you update the patch please? > Hi Michal,
Please review again, thanks. Hillf
===CUT HERE=== From: Hillf Danton <dhillf@gmail.com> Subject: [PATCH] mm: memcg: keep root group unchanged if fail to create new
If the request is to create non-root group and we fail to meet it, we should leave the root unchanged.
Signed-off-by: Hillf Danton <dhillf@gmail.com> Acked-by: Hugh Dickins <hughd@google.com> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> ---
--- a/mm/memcontrol.c Fri Dec 9 21:57:40 2011 +++ b/mm/memcontrol.c Mon Dec 12 21:47:14 2011 @@ -4848,9 +4848,9 @@ mem_cgroup_create(struct cgroup_subsys * int cpu; enable_swap_cgroup(); parent = NULL; - root_mem_cgroup = memcg; if (mem_cgroup_soft_limit_tree_init()) goto free_out; + root_mem_cgroup = memcg; for_each_possible_cpu(cpu) { struct memcg_stock_pcp *stock = &per_cpu(memcg_stock, cpu); @@ -4888,7 +4888,6 @@ mem_cgroup_create(struct cgroup_subsys * return &memcg->css; free_out: __mem_cgroup_free(memcg); - root_mem_cgroup = NULL; return ERR_PTR(error); }
| |