Messages in this thread |  | | Date | Mon, 12 Dec 2011 17:48:28 +0800 | | From | Mark Brown <> | | Subject | Re: [PATCH 1/2] MFD: MAX77693: add MAX77693 MFD driver |
| |
On Mon, Dec 12, 2011 at 06:02:40PM +0900, Donggeun Kim wrote: > On 2011년 12월 09일 18:58, Mark Brown wrote: > > On Fri, Dec 09, 2011 at 06:15:39PM +0900, Donggeun Kim wrote:
> >> + if (max77693_read_reg(i2c, MAX77693_PMIC_REG_PMIC_ID2, ®_data) < 0) {
> > I'd suggest also verifying that the ID register has the expected value. > > If there's a chip reision register logging it can be helpful.
> The all expected values for the register are not specified at datasheet. > The perpose of the read function is simply checking the existence of the > device so that the following operations are stopped for error case.
With a name like "ID" it's clearly chip idenfication - you should at least be displaying the value if it might change as it's likely to be useful for diagnostics. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |