lkml.org 
[lkml]   [2011]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Xen-devel] [PATCH 6/6] xen/xenbus-backend: Only register device if communication ring is local
    From
    Date
    On Sat, 2011-12-10 at 18:29 +0000, Bastian Blank wrote:
    > +/* A flag to determine if xenstored is 'local' */
    > +#ifdef CONFIG_XEN_BACKEND
    > +static int xenstored_local;
    > +#endif

    I think this can be __initdata since all the users are __init.

    > +#ifdef CONFIG_XEN_BACKEND
    > + xenstored_local = 1;

    I would push this down into xenstore_local_init() and only set it on
    success.

    > err = xenstored_local_init();

    This is now only called if CONFIG_XEN_BACKEND. You should add a similar
    #ifdef around the function definition.

    Ian.

    > if (err)
    > goto out_error;
    > +#else
    > + BUG();
    > +#endif
    > }
    > xen_store_interface = mfn_to_virt(xen_store_mfn);
    > }




    \
     
     \ /
      Last update: 2011-12-12 10:33    [W:0.022 / U:122.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site