Messages in this thread Patch in this message |  | | Subject | [PATCH] leds: mc13783: fix off-by-one for checking num_leds | | From | Axel Lin <> | | Date | Sat, 10 Dec 2011 15:14:56 +0800 |
| |
The LED id is begin from 0. Thus the maximum number of leds should be MC13783_LED_MAX + 1.
Signed-off-by: Axel Lin <axel.lin@gmail.com> --- drivers/leds/leds-mc13783.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c index c61e8c4..8bc4915 100644 --- a/drivers/leds/leds-mc13783.c +++ b/drivers/leds/leds-mc13783.c @@ -275,7 +275,7 @@ static int __devinit mc13783_led_probe(struct platform_device *pdev) return -ENODEV; } - if (pdata->num_leds < 1 || pdata->num_leds > MC13783_LED_MAX) { + if (pdata->num_leds < 1 || pdata->num_leds > (MC13783_LED_MAX + 1)) { dev_err(&pdev->dev, "Invalid led count %d\n", pdata->num_leds); return -EINVAL; } -- 1.7.5.4
|  |