lkml.org 
[lkml]   [2011]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH V2 0/1] making order in file2alias
On Fri, Dec 02, 2011 at 12:45:25AM +0100, Alessandro Rubini wrote:
> (this message is the RFC, the patch itself is expected to be fine)
>
> This is a repost of what I've sent on Nov 4th. Since Rusty asked to
> only do the first step, here it is. I rebased on next-20111201 and it
> still works fine.

Well, some of us disagree with Rusty :)

As he's still the maintainer of the module code, I'll defer to him
though.

> As for the previous 2/2 (see https://lkml.org/lkml/2011/11/4/127 ),
> I still think it makes sense. And as Dave Martin suggested, we can
> do without the array.
>
> Thus, I may prepare three smaller steps, if that's acceptable (greg?)
>
> step 1: create the ELF section so ENTRY() lines can leave the array
> (and change name accordingly).
>
> step 2: each ENTRY() line can be moved just after the associated code
> (this means that a new bus is just a single hunk, not 2 of them)
>
> step 3: I create the headers needed to move code and ENTRY in separate
> files. This is some movement around, not trivial so it may
> deserve a patch in itself.
>
> step 4 and later ones: Individual busses may reach their own external file,
> conditionally compiled per Kconfig rules.
>
> If that's something worth evaluating, I can do that over the weekend.

That sounds very reasonable to me.

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-12-02 01:07    [from the cache]
©2003-2011 Jasper Spaans