Messages in this thread | | | Date | Thu, 1 Dec 2011 12:54:57 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] mm: incorrect overflow check in shrink_slab() |
| |
On Thu, 1 Dec 2011 18:32:02 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> > total_scan is unsigned long, so the overflow check (total_scan < 0) > > didn't work. > > > > Signed-off-by: Xi Wang <xi.wang@gmail.com> > > Nice catch but.... the 'total_scan" shouldn't be long ? > Rather than type casting ?
Konstantin Khlebnikov's "vmscan: fix initial shrinker size handling" does change it to `long'. That patch is in -mm and linux-next and is queued for 3.3. It was queued for 3.2 but didn't make it due to some me/Dave Chinner confusion.
| |