Messages in this thread | | | From | Chris Ball <> | Subject | Re: [PATCH 07/11] mmc: Remove redundant spi driver bus initialization | Date | Thu, 01 Dec 2011 13:39:25 -0500 |
| |
Hi Lars,
On Thu, Nov 24 2011, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: Chris Ball <cjb@laptop.org> > Cc: linux-mmc@vger.kernel.org > --- > drivers/mmc/host/mmc_spi.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c > index 92946b8..273306c 100644 > --- a/drivers/mmc/host/mmc_spi.c > +++ b/drivers/mmc/host/mmc_spi.c > @@ -1525,7 +1525,6 @@ static struct of_device_id mmc_spi_of_match_table[] __devinitdata = { > static struct spi_driver mmc_spi_driver = { > .driver = { > .name = "mmc_spi", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > .of_match_table = mmc_spi_of_match_table, > },
Thanks, pushed to mmc-next for 3.3.
- Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/> One Laptop Per Child
| |