lkml.org 
[lkml]   [2011]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Guest stop notification
On 12/01/2011 06:19 PM, Eric B Munson wrote:
> On Thu, 01 Dec 2011, Jan Kiszka wrote:
>
>> On 2011-11-29 22:36, Eric B Munson wrote:
>>> +
>>> static void cpu_update_state(void *opaque, int running, RunState state)
>>> {
>>> CPUState *env = opaque;
>>>
>>> if (running) {
>>> env->tsc_valid = false;
>>> + kvm_put_guest_paused(env);
>>
>> checkpatch.pl would have asked you to remove this tab.
>
> Will change to spaces for V2.
>

Huh. Remove what tab? Indent are always 8-space TAB according
CodingStyle doc:

Chapter 1: Indentation

Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!)
characters deep, and that is akin to trying to define the value of PI to
be 3.


Gr. AvS



\
 
 \ /
  Last update: 2011-12-01 18:35    [W:0.082 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site