lkml.org 
[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[157/262] ext2,ext3,ext4: dont inherit APPEND_FL or IMMUTABLE_FL for new inodes
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit 1cd9f0976aa4606db8d6e3dc3edd0aca8019372a upstream.

    This doesn't make much sense, and it exposes a bug in the kernel where
    attempts to create a new file in an append-only directory using
    O_CREAT will fail (but still leave a zero-length file). This was
    discovered when xfstests #79 was generalized so it could run on all
    file systems.

    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/ext4/ext4.h | 3 +--
    include/linux/ext2_fs.h | 4 ++--
    include/linux/ext3_fs.h | 4 ++--
    3 files changed, 5 insertions(+), 6 deletions(-)

    --- a/fs/ext4/ext4.h
    +++ b/fs/ext4/ext4.h
    @@ -357,8 +357,7 @@ struct flex_groups {

    /* Flags that should be inherited by new inodes from their parent. */
    #define EXT4_FL_INHERITED (EXT4_SECRM_FL | EXT4_UNRM_FL | EXT4_COMPR_FL |\
    - EXT4_SYNC_FL | EXT4_IMMUTABLE_FL | EXT4_APPEND_FL |\
    - EXT4_NODUMP_FL | EXT4_NOATIME_FL |\
    + EXT4_SYNC_FL | EXT4_NODUMP_FL | EXT4_NOATIME_FL |\
    EXT4_NOCOMPR_FL | EXT4_JOURNAL_DATA_FL |\
    EXT4_NOTAIL_FL | EXT4_DIRSYNC_FL)

    --- a/include/linux/ext2_fs.h
    +++ b/include/linux/ext2_fs.h
    @@ -196,8 +196,8 @@ struct ext2_group_desc

    /* Flags that should be inherited by new inodes from their parent. */
    #define EXT2_FL_INHERITED (EXT2_SECRM_FL | EXT2_UNRM_FL | EXT2_COMPR_FL |\
    - EXT2_SYNC_FL | EXT2_IMMUTABLE_FL | EXT2_APPEND_FL |\
    - EXT2_NODUMP_FL | EXT2_NOATIME_FL | EXT2_COMPRBLK_FL|\
    + EXT2_SYNC_FL | EXT2_NODUMP_FL |\
    + EXT2_NOATIME_FL | EXT2_COMPRBLK_FL |\
    EXT2_NOCOMP_FL | EXT2_JOURNAL_DATA_FL |\
    EXT2_NOTAIL_FL | EXT2_DIRSYNC_FL)

    --- a/include/linux/ext3_fs.h
    +++ b/include/linux/ext3_fs.h
    @@ -180,8 +180,8 @@ struct ext3_group_desc

    /* Flags that should be inherited by new inodes from their parent. */
    #define EXT3_FL_INHERITED (EXT3_SECRM_FL | EXT3_UNRM_FL | EXT3_COMPR_FL |\
    - EXT3_SYNC_FL | EXT3_IMMUTABLE_FL | EXT3_APPEND_FL |\
    - EXT3_NODUMP_FL | EXT3_NOATIME_FL | EXT3_COMPRBLK_FL|\
    + EXT3_SYNC_FL | EXT3_NODUMP_FL |\
    + EXT3_NOATIME_FL | EXT3_COMPRBLK_FL |\
    EXT3_NOCOMPR_FL | EXT3_JOURNAL_DATA_FL |\
    EXT3_NOTAIL_FL | EXT3_DIRSYNC_FL)




    \
     
     \ /
      Last update: 2011-11-10 05:59    [W:4.139 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site