Messages in this thread | | | From | Axel Lin <> | Date | Wed, 9 Nov 2011 16:53:18 +0800 | Subject | Re: [PATCH v3] ASoC: wm9081: Use snd_soc_update_bits for read-modify-write |
| |
2011/11/9 Axel Lin <axel.lin@gmail.com>: >> /* VMID 2*4k; Soft VMID ramp enable */ >> - reg = snd_soc_read(codec, WM9081_VMID_CONTROL); >> - reg |= WM9081_VMID_RAMP | 0x6; >> - snd_soc_write(codec, WM9081_VMID_CONTROL, reg); >> + snd_soc_update_bits(codec, WM9081_VMID_CONTROL, >> + WM9081_VMID_RAMP | >> + WM9081_VMID_SEL_MASK, >> + WM9081_VMID_RAMP | 0x6); >> >> mdelay(100); >> >> /* Normal bias enable & soft start off */ >> - reg &= ~WM9081_VMID_RAMP;
oh.. wait. so original code does not clear WM9081_VMID_SEL_MASK bits here. My bad. Don't know why I always think WM9081_VMID_SEL_MASK bits are cleared here.
Will send a new version soon.
>> - snd_soc_write(codec, WM9081_VMID_CONTROL, reg); >> + snd_soc_update_bits(codec, WM9081_VMID_CONTROL, >> + WM9081_VMID_RAMP | >> + WM9081_VMID_SEL_MASK, 0); >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |