lkml.org 
[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[163/262] rtl8150: rtl8150_disconnect(...) does not need tasklet_disable(...)
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: huajun li <huajun.li.lee@gmail.com>

    commit c2e2a313ff8fdc25cedef5e63da712a6a0d35dfe upstream.

    Executing cmd 'rmmod rtl8150' does not return(if your device connects
    to host), the root cause is tasklet_disable() causes tasklet_kill()
    block, remove it from rtl8150_disconnect().

    Signed-off-by: Huajun Li <huajun.li.lee@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/net/usb/rtl8150.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/net/usb/rtl8150.c
    +++ b/drivers/net/usb/rtl8150.c
    @@ -977,7 +977,6 @@ static void rtl8150_disconnect(struct us
    usb_set_intfdata(intf, NULL);
    if (dev) {
    set_bit(RTL8150_UNPLUG, &dev->flags);
    - tasklet_disable(&dev->tl);
    tasklet_kill(&dev->tl);
    unregister_netdev(dev->netdev);
    unlink_all_urbs(dev);



    \
     
     \ /
      Last update: 2011-11-10 04:33    [W:0.020 / U:31.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site