[lkml]   [2011]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[004/262] TTY: drop driver reference in tty_open fail path
3.0-stable review patch.  If anyone has any objections, please let me know.


From: Jiri Slaby <>

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <>
Cc: Alan Cox <>
Acked-by: Sukadev Bhattiprolu <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/tty/tty_io.c | 1 +
1 file changed, 1 insertion(+)

--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1872,6 +1872,7 @@ got_driver:
if (IS_ERR(tty)) {
+ tty_driver_kref_put(driver);
return PTR_ERR(tty);

 \ /
  Last update: 2011-11-10 04:23    [W:0.490 / U:21.000 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site